chore: throw error when importing core twice #7784
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4fc27e6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wmertens
force-pushed
the
v2-throw-duplicate
branch
from
694fb2e to
80fa09c
Compare
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
the reason playwright errored and now the cli tests that both run vite in ssr server mode which loads vite config with uses qwik-router vite plugin, which imports qwik core, and then the preview server runs in-process with its own qwik core copy. So it's actually a bug in our bundling! |
this should make it easier to detect build misconfigurations
wmertens
force-pushed
the
v2-throw-duplicate
branch
from
80fa09c to
372c9da
Compare
still gets core via dev server
- remove separate dev-server which duplicated route processing logic, instead use node adapter - watch routes for changes and reload when needed - make route imports always dynamic (optionally static). This limits the amount of code to load when not all paths are visited, and reduces startup time. - remove .testing condition on double import, the reason was the dev-server importing core separately from the test code Still missing: - transformindexhtml handling - entry.ts support - serviceworker support
wmertens
force-pushed
the
v2-throw-duplicate
branch
from
cef66cb to
24463c5
Compare
wmertens
force-pushed
the
v2-throw-duplicate
branch
from
24463c5 to
dc4560b
Compare
wmertens
force-pushed
the
v2-throw-duplicate
branch
from
4743ea1 to
4fc27e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2 version of #7109 with vendorRoots removal
also features reworking the router build so it doesn't import core
TODO: remove vite-dev-server from qwik